Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up documentation #209

Merged
merged 10 commits into from
Apr 4, 2024
Merged

Clean up documentation #209

merged 10 commits into from
Apr 4, 2024

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Mar 20, 2024 •
edited
Loading

Closes #205

@edelarua edelarua added the sme label Mar 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024 •
edited
Loading

badge

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  ---------------------------------------------------------
R/paginate_listing.R        30       5  83.33%   80-85
R/rlistings_methods.R      101      16  84.16%   25-26, 40, 56, 60, 145-148, 151, 235-241
R/rlistings.R              178      26  85.39%   159-162, 165-168, 176, 209-213, 382-385, 389-392, 421-424
TOTAL                      309      47  84.79%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 9371dd1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024 •
edited
Loading

Unit Tests Summary

  1 files   5 suites   7s ⏱️
 37 tests 29 ✅  8 💤 0 ❌
104 runs  91 ✅ 13 💤 0 ❌

Results for commit 9371dd1.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 20, 2024 •
edited
Loading

Unit Test Performance Difference

Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
paginate_listing 💀 $0.02$ $-0.02$ defunct_is_defunct

Results for commit b16013f

♻️ This comment has been updated with latest results.

Melkiades
Melkiades reviewed Mar 21, 2024
View reviewed changes
R/rlistings_methods.R Outdated Show resolved Hide resolved
Melkiades
Melkiades approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@Melkiades Melkiades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Well done Emily! I only am wondering if we need to be more aligned with {tern} family with the parameter format definitions (e.g. flag instead of logical(1)). Also, made a couple of comments ;)

Melkiades
Melkiades reviewed Mar 25, 2024
View reviewed changes
R/rlistings.R Outdated Show resolved Hide resolved
@Melkiades
Copy link
Contributor

@edelarua sorry for the multiple conflicts. Can I ask you to add the dep on formatters 0.5.5.9017 ? Thanks Emily

@edelarua edelarua merged commit efb8f5d into main Apr 4, 2024
23 checks passed
@edelarua edelarua deleted the 264_clean_up_docs@main branch April 4, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Melkiades Melkiades Melkiades approved these changes

@ayogasekaram ayogasekaram Awaiting requested review from ayogasekaram ayogasekaram is a code owner

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Clean up documentation
2 participants
@edelarua @Melkiades